RFR: 8374168: Resolve disabled warnings in JDWP agent

[Chris Plummer]

On Sat, 20 Dec 2025 02:08:56 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The fix resolves disabled warnings in debugger agent

src/jdk.jdwp.agent/share/native/libjdwp/eventFilter.c line 980:

> 978: {
> 979:     // PlatformThreadsFilter contains nothing useful
> 980:     //PlatformThreadsFilter *filter = &FILTER(node, index).u.PlatformThreadsOnly;

I think you can just delete this.

src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 2678:

> 2676:     if (error != JVMTI_ERROR_NONE) {
> 2677:         EXIT_ERROR(error, "cannot get current thread");
> 2678:     }

I'm not sure about his one since it is a behavior change. For example, we have:

    jthread thread = threadControl_currentThread();
    if ((thread != NULL) && (!threadControl_isDebugThread(thread))) {
        threadControl_setPendingInterrupt(thread);
    }

src/jdk.jdwp.agent/share/native/libjdwp/util.h line 64:

> 62: /* To handle "format string is not a string literal" warning. */
> 63: #if !defined(_MSC_VER)
> 64:   #define ATTRIBUTE_PRINTF(fmt, vargs)  __attribute__((format(printf, fmt, vargs)))

Why not ATTRIBUTE_FORMAT?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2636723706
PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2636726418
PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2636726766