RFR: 8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400 [v2]

[Hao Sun]

On Sun, 21 Dec 2025 13:15:26 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move down the helper to avoid introducing new conditions
>>   
>>   Address mgronlun's comment
>
> src/hotspot/share/jfr/support/jfrClassDefineEvent.cpp line 129:
> 
>> 127: 
>> 128: #if INCLUDE_CDS
>> 129: static traceid get_source(const AOTClassLocation* cl, JavaThread* jt) {
> 
> You can just move down this static helper routine and put it before line 177; then no new conditionals needs to be introduced.

Thanks for your review.

Agree. Updated in the new commit.

Tests: JDK build with CDS disabled passed on both x86_64 and aarch64.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28917#discussion_r2641816038