RFR: 8373122: JFR build failure with CDS disabled due to -Werror=unused-function after JDK-8365400 [v2]
Hao Sun
haosun at openjdk.org
Tue Dec 23 08:40:01 UTC 2025
On Tue, 23 Dec 2025 03:33:08 GMT, Hao Sun <haosun at openjdk.org> wrote:
>> `get_source(const AOTClassLocation* cl, JavaThread* jt)` is only used by `JfrClassDefineEvent::on_restoration()` within an `INCLUDE_CDS` guard.
>>
>> Add the same `INCLUDE_CDS` guard to mitigate the GCC warning.
>>
>> Tests: JDK build with CDS disabled passed on both x86_64 and aarch64.
>> tier1~3 passed on both x86_64 and aarch64.
>
> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>
> Move down the helper to avoid introducing new conditions
>
> Address mgronlun's comment
Seems that I should backport this fix to jdk26 as this issue is a P3 bug and it affects jdk26 version as well.
Will create a backport PR soon.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28917#issuecomment-3685733710
More information about the build-dev
mailing list