RFR: 8323158: HotSpot Style Guide should specify more include ordering [v2]

Thomas Stuefe stuefe at openjdk.org
Tue Feb 4 14:08:10 UTC 2025


On Mon, 3 Feb 2025 12:14:35 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The HotSpot Style Guide has a section about source files and includes. The style used for includes have mostly been introduced by scripts when includeDB was replaced, but also when various other enhancements to our includes were made. Some of the introduced styles were never written down in the style guide.
>> 
>> I propose a couple of changes to the HotSpot Style Guide to reflect some of these implicit styles that we have. While updating the text I also took the liberty to order the items in an order that I felt was good.
>> 
>> Note that JDK-8323158 contains a few more suggestions, but I've only addressed the items that I think can be accepted without much contention. Either I extract the items that have not been address into a new RFE, or I create a new RFE for this PR.
>> 
>> There a some small whitespace tweaks that I made so that the .md and .html had a similar layout.
>
> Stefan Karlsson has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update hotspot-style.md
>  - Update hotspot-style.html

This looks good to me. Thank you.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23388#pullrequestreview-2592970726


More information about the build-dev mailing list