RFR: 8349140: Size optimization (opt-size) build fails after recent PCH changes

Matthias Baesken mbaesken at openjdk.org
Tue Feb 4 15:40:25 UTC 2025


When using the configure flag --enable-jvm-feature-opt-size (linux x86_64 opt build, gcc 11 devkit) we run into this error after the recent PCH related changes :


cc1plus: error: /build_optsize/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.gch: not used because `__OPTIMIZE_SIZE__' not defined [-Werror=invalid-pch]

+ exit 1
gmake[3]: *** [lib/CompileJvm.gmk:170: /build_optsize/hotspot/variant-server/libjvm/objs/allocation.o] Error 1


Please note that allocation.cpp is currently in the list of `OPT_SPEED_SRC` files (means - files to be optimized for speed even in case of SIZE optimization) :
https://github.com/openjdk/jdk/blob/master/make/hotspot/lib/JvmFeatures.gmk#L196

Same issue can be observed on Windows x86_64 (VS2022 used).

-------------

Commit messages:
 - JDK-8349140

Changes: https://git.openjdk.org/jdk/pull/23442/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23442&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8349140
  Stats: 18 lines in 1 file changed: 1 ins; 12 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/23442.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23442/head:pull/23442

PR: https://git.openjdk.org/jdk/pull/23442


More information about the build-dev mailing list