RFR: 8323158: HotSpot Style Guide should specify more include ordering [v2]

Stefan Karlsson stefank at openjdk.org
Wed Feb 5 08:53:20 UTC 2025


On Wed, 5 Feb 2025 08:49:59 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> doc/hotspot-style.html line 213:
>> 
>>> 211: <li><p>Put conditional inclusions (`#if ...`) at the end of the section of HotSpot
>>> 212: include lines. This also applies to macro-expanded includes of platform
>>> 213: dependent files.</p></li>
>> 
>> What is the order for the conditional sections? Alphabetic on the include guard?
>
> I don't think there's a set order. I wouldn't mind making it alphabetic with platforms includes coming before the other conditional includes.

FWIW, I also tend to sort the forward declarations but that's also not something that everyone does.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23388#discussion_r1942464777


More information about the build-dev mailing list