RFR: 8349284: Make libExplicitAttach work on static JDK

Alan Bateman alanb at openjdk.org
Fri Feb 7 10:41:00 UTC 2025


On Thu, 6 Feb 2025 20:14:36 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

> This is similar to https://github.com/openjdk/jdk/pull/23431 change. It removes libjvm.so as a recorded dependency for libExplicitAttach.so by not explicitly link libExplicitAttach.so with libjvm.so at build time. To do that, it also changes libExplicitAttach.c to dynamically lookup the JNI_GetCreatedJavaVMs symbol then invokes the function using the obtained address. The change makes the test to work on both regular 'jdk' image and the 'static-jdk' image.
> 
> There are discussions in https://github.com/openjdk/jdk/pull/23431 comment thread among @dholmes-ora, @AlanBateman and myself. Based on my understanding, we are converging on the approach to fix just these few tests, and both @dholmes-ora and @AlanBateman are okay with that. So I'm sending out this PR for libExplicitAttach's fix as well.

Can you look at adding native init method instead? This could be called from the System.loadLibraray and avoid introduce a side effect of startThreads initialising GetCreatedJavaVMs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23500#issuecomment-2642552698


More information about the build-dev mailing list