RFR: 8349284: Make libExplicitAttach work on static JDK [v5]

Jiangli Zhou jiangli at openjdk.org
Mon Feb 10 17:41:55 UTC 2025


> This is similar to https://github.com/openjdk/jdk/pull/23431 change. It removes libjvm.so as a recorded dependency for libExplicitAttach.so by not explicitly link libExplicitAttach.so with libjvm.so at build time. To do that, it also changes libExplicitAttach.c to dynamically lookup the JNI_GetCreatedJavaVMs symbol then invokes the function using the obtained address. The change makes the test to work on both regular 'jdk' image and the 'static-jdk' image.
> 
> There are discussions in https://github.com/openjdk/jdk/pull/23431 comment thread among @dholmes-ora, @AlanBateman and myself. Based on my understanding, we are converging on the approach to fix just these few tests, and both @dholmes-ora and @AlanBateman are okay with that. So I'm sending out this PR for libExplicitAttach's fix as well.

Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright year.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23500/files
  - new: https://git.openjdk.org/jdk/pull/23500/files/317d2315..98d1dea8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23500&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23500&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/23500.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23500/head:pull/23500

PR: https://git.openjdk.org/jdk/pull/23500


More information about the build-dev mailing list