Integrated: 8349284: Make libExplicitAttach work on static JDK
Jiangli Zhou
jiangli at openjdk.org
Mon Feb 10 20:22:15 UTC 2025
On Thu, 6 Feb 2025 20:14:36 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> This is similar to https://github.com/openjdk/jdk/pull/23431 change. It removes libjvm.so as a recorded dependency for libExplicitAttach.so by not explicitly link libExplicitAttach.so with libjvm.so at build time. To do that, it also changes libExplicitAttach.c to dynamically lookup the JNI_GetCreatedJavaVMs symbol then invokes the function using the obtained address. The change makes the test to work on both regular 'jdk' image and the 'static-jdk' image.
>
> There are discussions in https://github.com/openjdk/jdk/pull/23431 comment thread among @dholmes-ora, @AlanBateman and myself. Based on my understanding, we are converging on the approach to fix just these few tests, and both @dholmes-ora and @AlanBateman are okay with that. So I'm sending out this PR for libExplicitAttach's fix as well.
This pull request has now been integrated.
Changeset: 527489c0
Author: Jiangli Zhou <jiangli at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/527489c06d827f5d08a8053bedcd26db4608c9f0
Stats: 18 lines in 2 files changed: 7 ins; 10 del; 1 mod
8349284: Make libExplicitAttach work on static JDK
Reviewed-by: alanb, dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/23500
More information about the build-dev
mailing list