RFR: 8349378: Build splashscreen lib with SIZE optimization
Matthias Baesken
mbaesken at openjdk.org
Wed Feb 12 08:58:11 UTC 2025
On Fri, 7 Feb 2025 22:45:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>>> What tests have you run?
>>
>> Had this in our internal test queue with jtreg / JCK plus some additional SAP internal tests. No issues seen.
>> However I think I have to run some more manual tests on client like setups.
>>
>> Unfortunately my Linux terminal server does not like the awt jtreg tests (with and without my patch) , so I have to find something else.
>
> @MBaesken
>
>> However I think I have to run some more manual tests on client like setups.
>
> SplashScreen clientlib tests are located - test/jdk/java/awt/SplashScreen. Most of them are manual tests invoked by shell script and it is easier to run the whole test folder. I can run the tests on your behalf to check if the tests work fine with the fix.
>
> What are we specifically looking for in the tests with this fix? No degradation in test startup and execution time?
@honkar-jdk do you have the latest/newest jdk head, especially this change is important
8349214: Improve size optimization flags for MSVC builds
https://github.com/openjdk/jdk/commit/40603a5bf039eef03c157bfc49ac8ea2229a94de
Before the SIZE opt flags for MSVC were bad.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23493#issuecomment-2653033507
More information about the build-dev
mailing list