Integrated: 8349781: make test TEST=gtest fails on WSL

Daniel Jeliński djelinski at openjdk.org
Wed Feb 12 09:07:13 UTC 2025


On Tue, 11 Feb 2025 07:46:54 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> `make test TEST=gtest` fails to run gtest on WSL. This is because we're looking for a nonexistent file `gtestLauncher`; on Windows the file is named `gtestLauncher.exe`.
> 
> This PR adds `$EXECUTABLE_SUFFIX` to the executable path, similar to what [GtestImage.gmk already does](https://github.com/openjdk/jdk/blob/64bd8d2592d26e02a7f2f96caa47cba5e158aaa2/make/hotspot/test/GtestImage.gmk#L37).
> 
> I verified that with the proposed change, `make test TEST=gtest` works correctly both on WSL and on Cygwin. Other platforms are unaffected, because EXECUTABLE_SUFFIX is [empty on all non-Windows platforms](https://github.com/openjdk/jdk/blob/64bd8d2592d26e02a7f2f96caa47cba5e158aaa2/make/autoconf/toolchain.m4#L188).

This pull request has now been integrated.

Changeset: 08f4c1c8
Author:    Daniel Jeliński <djelinski at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/08f4c1c801c8c3553c1380e1d019a487bd0a25ea
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8349781: make test TEST=gtest fails on WSL

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/23555


More information about the build-dev mailing list