RFR: 8349934: Wrong file regex for copyright header format check in .jcheck/conf

Zhao Song zsong at openjdk.org
Wed Feb 12 19:55:44 UTC 2025


The copyright header format check was introduced in [JDK-8346046](https://bugs.openjdk.org/browse/JDK-8346046). However, a user recently reported that the check doesn't catch incorrect copyright headers in this pr(https://github.com/openjdk/jdk/pull/23550).

After investigation, I found that the issue was caused by the file regex in .jcheck/conf. There is a redundant "|" character after ".*.jar".

`files=^(?!LICENSE|license.txt|.*.bin|.*.gif|.*.jpg|.*.png|.*.icon|.*.tiff|.*.dat|.*.patch|.*.wav|.*.class|.*-header|.*.jar|).*`

This redundant "|" prevents the regex from matching any string.

-------------

Commit messages:
 - JDK-8349934

Changes: https://git.openjdk.org/jdk/pull/23598/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23598&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8349934
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/23598.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23598/head:pull/23598

PR: https://git.openjdk.org/jdk/pull/23598


More information about the build-dev mailing list