Integrated: 8349934: Wrong file regex for copyright header format check in .jcheck/conf

Zhao Song zsong at openjdk.org
Wed Feb 12 21:39:15 UTC 2025


On Wed, 12 Feb 2025 19:49:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

> The copyright header format check was introduced in [JDK-8346046](https://bugs.openjdk.org/browse/JDK-8346046). However, a user recently reported that the check doesn't catch incorrect copyright headers in this pr(https://github.com/openjdk/jdk/pull/23550).
> 
> After investigation, I found that the issue was caused by the file regex in .jcheck/conf. There is a redundant "|" character after ".*.jar".
> 
> `files=^(?!LICENSE|license.txt|.*.bin|.*.gif|.*.jpg|.*.png|.*.icon|.*.tiff|.*.dat|.*.patch|.*.wav|.*.class|.*-header|.*.jar|).*`
> 
> This redundant "|" prevents the regex from matching any string.

This pull request has now been integrated.

Changeset: 7a0832f5
Author:    Zhao Song <zsong at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7a0832f5487cb7586131f6c4e0b90300f6de5dec
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8349934: Wrong file regex for copyright header format check in .jcheck/conf

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/23598


More information about the build-dev mailing list