RFR: 8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel
Jiangli Zhou
jiangli at openjdk.org
Thu Feb 13 19:11:23 UTC 2025
On Wed, 12 Feb 2025 23:37:44 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>>> @bplb You may have to double check that this works for us.
>>
>> Thanks!
>>
>> @bplb, please let me know your internal testing result. If there's no additional internal test source changes in those native libraries, I think testing should not run into any issue. These tests native code only uses standard JNI APIs.
>
>> I think testing should not run into any issue
>
> I did not find any problem for the tests in the [jdk_nio](https://github.com/openjdk/jdk/blob/55097dd4cbb5d691c12cb0247d66dce593759d59/test/jdk/TEST.groups#L206) group on Linux, macOS, or Windows. This test group includes in particular these tests
>
> java/nio/jni/NewDirectByteBuffer.java
> java/nio/channels/FileChannel/directio
> java/nio/channels/spi/SelectorProvider/inheritedChannel
>
> which the proposed change specifically would affect.
@bplb Thanks again for the review and running internal testing!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23575#issuecomment-2657488985
More information about the build-dev
mailing list