RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG_AOT_JDK=true" [v3]
Ioi Lam
iklam at openjdk.org
Fri Feb 14 05:59:52 UTC 2025
> When running HotSpot jtreg tests in the "AOT mode", for example:
>
>
> make test JTREG_AOT_JDK=true open/test/hotspot/jtreg/runtime/stringtable
>
>
> Before this PR, in the test set up phase, we record several AOT configuration files by running a few separate Java tools (javac, javap, jlink, and jar), and then combine them together with sed, grep, sort and uniq:
>
> https://github.com/openjdk/jdk/blob/adc3f53d2403cd414a91e71c079b4108b2346da0/make/RunTests.gmk#L723-L744
>
> After [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), the AOT configuration file will change to a binary format and can no longer be edited this way. In preparation for [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), we should change the "JTREG_AOT_JDK=true" set up to run a single Java program that accomplishes the same effect as the current implementation.
>
> ** Changes in this PR **
>
> This PR combines the invocation of these Java tools into a single Java program, so we just have a single AOT configuration file. It also uses the `-XX:ExtraSharedClassListFile` option to include the default classlist from the JDK home directory,
Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into 8349953-avoid-edit-aot-config-with-jtreg-aot-jdk
- Comments from @erikj79
- 8349953: Avoid editing AOTConfiguration file in "make test JTREG_AOT_JDK=true"
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23620/files
- new: https://git.openjdk.org/jdk/pull/23620/files/c1aaf635..ed727488
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23620&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23620&range=01-02
Stats: 1992 lines in 34 files changed: 1757 ins; 122 del; 113 mod
Patch: https://git.openjdk.org/jdk/pull/23620.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23620/head:pull/23620
PR: https://git.openjdk.org/jdk/pull/23620
More information about the build-dev
mailing list