RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v4]
Weijun Wang
weijun at openjdk.org
Fri Feb 14 19:27:12 UTC 2025
On Fri, 14 Feb 2025 18:19:17 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> test/lib/jdk/test/lib/security/XMLUtils.java line 557:
>>
>>> 555: }
>>> 556:
>>> 557: // MISC
>>
>> This is a section break for various groups of methods in this utility class. Before this there have been
>>
>> //////////// CONVERT ////////////
>> //////////// QUERY AND EDIT ////////////
>> //////////// SIGN ////////////
>> //////////// VALIDATE ////////////
>>
>> Can you keep the format?
>
> sure, since such comments are cause warning, i just suppress them.
Oh, they were recognized as Markdown javadoc? I didn't think of that.
It's strange that the other 4 show no warning, and then I noticed that changing it to
//////////// MISC ////////////
// Adds a new rule to "jdk.xml.dsig.secureValidationPolicy"
can also let the warning go away. The problem is it now treats the `///` line as javadoc and `//` as nothing. This is definitely not right. Maybe I'll do some cleanup later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23525#discussion_r1956622006
More information about the build-dev
mailing list