RFR: 8350051: [JMH] Several tests fails NPE [v2]
SendaoYan
syan at openjdk.org
Wed Feb 19 03:25:01 UTC 2025
On Tue, 18 Feb 2025 20:18:12 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Use SetupCopyFiles macro to copy the dependency files
>
> make/test/BuildMicrobenchmark.gmk line 127:
>
>> 125: $(TOPDIR)/test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/message_12.xml \
>> 126: $(TOPDIR)/test/jaxp/javax/xml/jaxp/unittest/transform/msgAttach.xml \
>> 127: $(MICROBENCHMARK_CLASSES)/org/openjdk/bench/javax/xml
>
> If this is the correct solution, then copying these files should be handled separately from unpacking jars, preferably using a SetupCopyFiles macro call. Something like this (untested):
>
> $(eval $(call SetupCopyFiles, COPY_JAXP_TEST_XML, \
> DEST := $(MICROBENCHMARK_CLASSES)/org/openjdk/bench/javax/xml, \
> FILES := \
> $(TOPDIR)/test/jaxp/javax/xml/jaxp/unittest/validation/tck/reZ003vExc23082309.xml \
> $(TOPDIR)/test/jaxp/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/message_12.xml \
> $(TOPDIR)/test/jaxp/javax/xml/jaxp/unittest/transform/msgAttach.xml, \
> FLATTEN := true, \
> ))
>
> And then add $(COPY_JAXP_TEST_XML) to the list of dependencies in the `SetupJarArchive` call below.
The `SetupCopyFiles` macro seems do not support multiple absolute path `FILES` arguments, so I use relative path instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23625#discussion_r1960893035
More information about the build-dev
mailing list