RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools [v2]
Nizar Benalla
nbenalla at openjdk.org
Wed Feb 19 16:05:15 UTC 2025
> This patch fixes a regression where the windows tools man pages appeared on the Linux and the MacOS builds
>
> The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` used to generate the documentation for the JDK as well as in `LauncherCommon.gmk` here https://github.com/openjdk/jdk/blob/efbad00c4d7931177ccc5e9bce3b30dfbac94010/make/common/modules/LauncherCommon.gmk#L195
>
> I've separated the logic between generated the docs and the man pages. I've checked on a MacOs machine and the man pages no longer appear.
>
> This patch will need to be backported to JDK 24.
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
respond to feedback
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23697/files
- new: https://git.openjdk.org/jdk/pull/23697/files/ae7fbae6..6b5f20ae
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23697&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23697&range=00-01
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/23697.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23697/head:pull/23697
PR: https://git.openjdk.org/jdk/pull/23697
More information about the build-dev
mailing list