Integrated: 8349953: Avoid editing AOTConfiguration file in "make test JTREG=AOT_JDK=true"

Ioi Lam iklam at openjdk.org
Thu Feb 20 02:16:02 UTC 2025


On Thu, 13 Feb 2025 17:45:45 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> When running HotSpot jtreg tests in the "AOT mode", for example:
> 
> 
> make test JTREG=AOT_JDK=true TEST=open/test/hotspot/jtreg/runtime/stringtable
> 
> 
> Before this PR, in the test set up phase, we record several AOT configuration files by running a few separate Java tools (javac, javap, jlink, and jar), and then combine them together with sed, grep, sort and uniq:
> 
> https://github.com/openjdk/jdk/blob/adc3f53d2403cd414a91e71c079b4108b2346da0/make/RunTests.gmk#L723-L744
> 
> After [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), the AOT configuration file will change to a binary format and can no longer be edited this way. In preparation for [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), we should change the "JTREG_AOT_JDK=true" set up to run a single Java program that accomplishes the same effect as the current implementation.
> 
> ** Changes in this PR **
> 
> This PR combines the invocation of these Java tools into a single Java program, so we just have a single AOT configuration file. It also uses the `-XX:ExtraSharedClassListFile` option to include the default classlist from the JDK home directory,

This pull request has now been integrated.

Changeset: 0131c1bf
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0131c1bfd8ccfdf4f3d73cddfc2a87e2a6e99581
Stats:     194 lines in 5 files changed: 158 ins; 18 del; 18 mod

8349953: Avoid editing AOTConfiguration file in "make test JTREG=AOT_JDK=true"

Reviewed-by: erikj, ccheung

-------------

PR: https://git.openjdk.org/jdk/pull/23620


More information about the build-dev mailing list