RFR: 8350443: GHA: Split static-libs-bundles into a separate job
Doug Simon
dnsimon at openjdk.org
Thu Feb 20 19:52:52 UTC 2025
On Thu, 20 Feb 2025 17:15:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Noticed this when reviewing [JDK-8349399](https://bugs.openjdk.org/browse/JDK-8349399), which had to kludgy workaround the hunk introduced by `static-libs-bundles` addition ([JDK-8337265](https://bugs.openjdk.org/browse/JDK-8337265)). I am somewhat surprised we even have `static-libs-bundles` as additional target in what I would consider a generic build-linux job! It looks cleaner to yank `static-libs-bundles` into a separate build job.
>
> This effectively reverts parts of the original change, and does a few modifications:
> - I see no reason to store the bundles, and continuing to do so would effectively overwrite `linux-x64-bundles` when we split the static build into another job, breaking tests. Not sure why we had to publish those bundles, @dougxc? They are not used in current JDK tests, I think?
> - The matrix definition in `build-linux.xml` unconditionally includes `debug` configuration to override flags and suffix, I had to redo this with inline variables
>
> Named the new job `linux-x64-static`, since I expect @jianglizhou to slide https://github.com/openjdk/jdk/pull/23471 just there by adding another `make-target` into that job definition.
>
> I did a partial GHA run already, and I expect full run to complete without errors.
>
> Testing:
> - [x] GHA
Please do not remove the static-lib-bundles - they are critical for testing OpenJDK PRs against libgraal: https://github.com/dougxc/openjdk-pr-canary/blob/9c38cdb2dcdbe4aef6b81732b3a296856ac1bb4c/.github/scripts/test-openjdk-pullrequests.py#L818
cc @mur47x111
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23715#issuecomment-2672527713
More information about the build-dev
mailing list