RFR: 8350041: Make libstringPlatformChars support static JDK
Jiangli Zhou
jiangli at openjdk.org
Thu Feb 20 23:47:10 UTC 2025
On Fri, 14 Feb 2025 18:31:52 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> Please review the fix to make `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test:
>
> - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and `JNU_NewStringPlatform` dynamically
> - Remove `#include "jni_util.h"` and don't link `libstringPlatformChars.so` with `libjava.so`
> - Link with `-ldl` explicitly
>
> The test passed on Linux, macos and Windows in GHA testing, https://github.com/jianglizhou/jdk/actions/runs/13320840902/job/37206171224
> > I don't object to changing this test but it might be simpler to just skip this test, once we can use `@requires !jdk.static`.
>
> Thanks, @AlanBateman. I think skipping this test for static JDK sounds reasonable to me, since this test seems to explicitly test these JNU_ functions. Changing to do dynamic lookup may alter the original intention. I'll update after #23528.
Updated to skipping `java/lang/String/nativeEncoding/StringPlatformChars.java` on static JDK.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23646#issuecomment-2672961034
More information about the build-dev
mailing list