RFR: 8261669: Add lint warning for widening primitive conversions that lose information [v2]
Archie Cobbs
acobbs at openjdk.org
Fri Feb 21 16:51:38 UTC 2025
> This PR is a prototype to stimulate discussion of [JDK-8261669](https://bugs.openjdk.org/browse/JDK-8261669), which seeks to add more warnings when an implicit cast of a primitive value might lose information. This can possibly happen when converting an `int` to `float`, or when converting a `long` to `float` or `double`. Java does not require an explicit cast for such assignments, even though they may result in information loss.
>
> I'm interested in feedback both on whether this is a good idea and also the approach taken - thanks!
>
> Currently, we generate this warning, but only for assignment operators, e.g.:
>
> int x = 0;
> x += 1.0f; // warning here
>
>
> This PR would add warnings for two additional cases, (a) regular assignments and (b) method parameters, e.g.:
>
> void method(float f) { }
> ...
> float a = 0x10000001; // warning here
> method(0x10000001); // warning here
>
>
> It would _not_ generate a warning in cases (a) and (b) when the value is a constant value and we can determine that no information would be lost, e.g.:
>
> float f1 = 0x10000000; // no warning here
>
> The definition of "no information would be lost" is that a round trip results in the same value, e.g., `(int)(float)x == x`. In the examples above, `0x10000000` survives the round trip but `0x10000001` does not.
>
> As usual, warnings can be suppressed via `@SuppressWarnings` or by adding an explicit cast:
>
>
> float a = (float)0x10000001; // no warning here
Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
Check exactness of conversions using ExactConversionsSupport.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23718/files
- new: https://git.openjdk.org/jdk/pull/23718/files/48680ecb..92b479a9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23718&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23718&range=00-01
Stats: 98 lines in 5 files changed: 64 ins; 2 del; 32 mod
Patch: https://git.openjdk.org/jdk/pull/23718.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23718/head:pull/23718
PR: https://git.openjdk.org/jdk/pull/23718
More information about the build-dev
mailing list