RFR: 8350118: Simplify the layout access VarHandle [v2]

Chen Liang liach at openjdk.org
Fri Feb 21 20:14:19 UTC 2025


> Simplify the layout access var handles to be direct in some common cases. Also made `VarHandle::isAccessModeSupported` report if an access mode is supported for a VH.
> 
> Reduces the instructions to execute this code in a simple main by 47%:
> 
> long[] arr = new long[8];
> var ms = MemorySegment.ofArray(arr);
> ms.setAtIndex(ValueLayout.JAVA_BYTE, 12, (byte) 3);
> 
> 
> Main overheads in FFM are identified to be:
> 1. Eager initialization of direct MethodHandle; can be CDS archived
> 2. MH combinator forms via LambdaFormEditor, not cached right now and always have large overhead
> 
> Still need other measures to deal with common user patterns of `MethodHandles.insertCoordinates(vh, 1, 0L)` which currently is still very slow.
> 
> Tests: 2 unrelated failures on tier 1-3

Chen Liang has updated the pull request incrementally with one additional commit since the last revision:

  Review remarks, dates, some more simplifications

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23720/files
  - new: https://git.openjdk.org/jdk/pull/23720/files/02c6faa1..c4af6ebf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23720&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23720&range=00-01

  Stats: 427 lines in 13 files changed: 136 ins; 113 del; 178 mod
  Patch: https://git.openjdk.org/jdk/pull/23720.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23720/head:pull/23720

PR: https://git.openjdk.org/jdk/pull/23720


More information about the build-dev mailing list