RFR: 8350118: Simplify the layout access VarHandle [v2]

Magnus Ihse Bursie ihse at openjdk.org
Tue Feb 25 14:41:54 UTC 2025


On Fri, 21 Feb 2025 20:17:09 GMT, Chen Liang <liach at openjdk.org> wrote:

>>> I have disabled them with #, and the status is confirmed by test for access modes. I kept the infra to make future reenabling easy.
>> 
>> Doh - I missed the `#` -- maybe add few more to make that more explicit? (I agree with the approach)
>
> Left a space and an extra note to make the comment hash more obvious.

Unless you plan to shortly push a new PR where you either enable this functionality, or remove the commented-out lines, I strongly prefer *not* to have commented-out code in the makefiles. It's not that hard to re-create these lines should they be needed. And you can always find the history in this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1969917926


More information about the build-dev mailing list