RFR: 8346987: [lto] gtest build fails

[Magnus Ihse Bursie]

On Mon, 24 Feb 2025 11:38:40 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>>> I'll try to prioritize separating gtest and hotspot builds, and then it will be possible to fix this in a clean way.
>> 
>> Okay thanks, then let's wait a bit for your change  separating gtest and hotspot builds, if this helps to make the change nicer.
>
>> I'll try to prioritize separating gtest and hotspot builds, and then it will be possible to fix this in a clean way.
> 
> Hi @magicus was there some progress on this topic ?

@MBaesken @tstuefe Hi guys, sorry I've been absent for a while. :-(

I have not been making any progress on this as of my last comment. 

Regarding my plans, the JBS issue is deliberately a bit vague since I will need to do a bit of research to figure out the best way to do this. But my rough idea is that we should just split the current code into two different make targets, one that only compiles and links .o files for the "real" libjvm.so, and a separate one that compiles and links .o files for the gtest libjvm.so. This target would depend on the target producing the "real" libjvm.so, so it will have access to all .o files generated by it. I can't see any obvious reason why this would not work, but since it was never done like that from the start (which I think would have been the obvious thing to do), maybe there are some twists that I'm missing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23173#issuecomment-2682345096