RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v3]
Aleksey Shipilev
shade at openjdk.org
Wed Feb 26 19:47:55 UTC 2025
On Wed, 26 Feb 2025 18:24:13 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review this change that adds a `linux-x86-static` job in GHA. The job builds the `static-jdk-image` release binary on linux-x64. Please see https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for some additional context.
>>
>> A `debug` build job (building `static-jdk-image` fastdebug binary) is not included currently. There is a known issue that causes build failure due to resource problem, which causes the `fastdebug` build fail in github workflow. Please see more related information in https://bugs.openjdk.org/browse/JDK-8349399?focusedId=14749789&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14749789.
>>
>> GHA: https://github.com/jianglizhou/jdk/actions/runs/13163673020
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename build-linux-x64-static-jdk back to build-linux-x64-static and move close to build-linux-x64-static-libs, for addressing shipilev's suggestions.
Changes requested by shade (Reviewer).
.github/workflows/main.yml line 241:
> 239: configure-arguments: ${{ github.event.inputs.configure-arguments }}
> 240: make-arguments: ${{ github.event.inputs.make-arguments }}
> 241: if: needs.prepare.outputs.linux-x64 == 'true'
Ah, one more trouble: this job produces bundles. But that bundle name is just `linux-x64`, which overrides the standard bundle. See how `build-linux-x64-static-libs` overrides `bundle-suffix:`, do the same here. E.g. `bundle-suffix: -static`?
-------------
PR Review: https://git.openjdk.org/jdk/pull/23471#pullrequestreview-2645688559
PR Review Comment: https://git.openjdk.org/jdk/pull/23471#discussion_r1972279433
More information about the build-dev
mailing list