RFR: 8350118: Simplify the layout access VarHandle [v2]

Chen Liang liach at openjdk.org
Wed Feb 26 20:13:42 UTC 2025


On Wed, 26 Feb 2025 17:26:41 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java line 331:
> 
>> 329: 
>> 330:     @ForceInline
>> 331:     public static int unboxSegment32(MemorySegment segment) {
> 
> Could you add a comment here:
> Suggestion:
> 
>     public static int unboxSegment32(MemorySegment segment) {
>         // this cast to 'int' is safe, because we only call this method on 32-bit platforms, where we know the address of a segment is truncated to 32-bits.

Done, pushed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1972329235


More information about the build-dev mailing list