RFR: 8343832: Enhance test summary with number of skipped tests [v8]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Feb 27 16:15:05 UTC 2025
On Thu, 27 Feb 2025 16:10:17 GMT, Ivan Bereziuk <duke at openjdk.org> wrote:
>> The output for Jtreg v7.5 was [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) with [information about skipped tests](https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#what-do-all-those-numbers-in-the-test-results-line-mean).
>>
>> Use the additional information in the "summary" block printed at the end of `make test` target.
>
> Ivan Bereziuk has updated the pull request incrementally with two additional commits since the last revision:
>
> - Merge pull request #1 from magicus/fix-skipped-tests
>
> Fix so skipped tests are not considered failures
> - Fix so skipped tests are not considered failures
Looks good now to me. Technically, I assume it would be good if you get a re-review of the latest commit, since I should not be reviewing my own code.
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22245#pullrequestreview-2648329385
More information about the build-dev
mailing list