RFR: 8348028: Unable to run gtests with CDS enabled [v4]

Magnus Ihse Bursie ihse at openjdk.org
Fri Feb 28 10:23:58 UTC 2025


On Fri, 28 Feb 2025 00:37:24 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> A simple fix in `os::jvm_path()` so that gtest can be run with CDS (`-Xshare:on`). The fix is just to change the directory name from `hotspot` to `server`.
>> Note that the bug doesn't exist on macOS and thus no change is required for `os_bsd.cpp`.
>> 
>> Testing:
>> 
>> - run gtest with -Xshare:on on linux-x64
>> - tier1
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @magius and @iklam comments

This looks good from a build perspective!

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23758#pullrequestreview-2650346184


More information about the build-dev mailing list