RFR: 8346986: Remove ASM from java.base

[David Holmes]

On Tue, 7 Jan 2025 20:19:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test libraries location and fixes the tests.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Moving it to test/hotspot/jtreg is initially surprising, I assumed it would move to test/lib. Did you choose the hotspot tree as only tests in hotspot/jtreg use it and you didn't want to add or change the @library tag on these tests?
> 
> The other thing is the package name, maybe it should move back to org.objectweb.asm as it won't be a JDK internal package.

I also agree with @AlanBateman  about the package name. It is not appropriate for anything outside the platform modules to claim to be part of `jdk.internal`. In fact I'm surprised we are even allowed to add to that from outside the module!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22946#issuecomment-2576516315