RFR: 8347120: Launchers should not have java headers on include path

David Holmes dholmes at openjdk.org
Wed Jan 8 06:02:38 UTC 2025


On Tue, 7 Jan 2025 17:34:10 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The launcher src does not need any of the Java generated headers to compile, yet we are currently adding that directory to the include path. This is usually not a problem, but can cause a race that triggers unwanted recompilation in incremental builds (see bug description for details). This patch fixes this issue by not adding these directories to the include path when building the launcher.

Based on your analysis this seems quite reasonable.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22953#pullrequestreview-2536079032


More information about the build-dev mailing list