RFR: 8346986: Remove ASM from java.base

[Adam Sotona]

On Wed, 8 Jan 2025 01:45:48 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test libraries location and fixes the tests.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> I think it is make sense to put ASM into hotspot testlibrary if there are no any other users. So it is clear that non-hotspot tests don't depend on it.
> There is a location
> test/hotspot/jtreg/testlibrary 
> for hotstpot specific libraries.
> Could you please move it here.
> 
> Before renaming packages, I would like to understand if we can move to standard ASM? We are no planning to develop new tests and maintain this library for newer releases. Otherwise, keeping jdk.internal simplify backporting changes.
> 
> It is not possible to implement it as a precompiled library because of jtreg limitations to find jars in test-images. So I'll implement this later.

I agree with @lmesnik that any unnecessary repackaging would affect backporting compatibility (>1200 unnecessary changes across >250 source files causing potential conflicts).

My question to test/hotspot/jtreg/testlibrary - is it effective to mix existing testlibrary with ASM. From the hotspot tests I see not all tests requiring testlibrary need ASM and vice versa. And many tests include other test libraries. However maybe it is irrelevant.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22946#issuecomment-2576876491