RFR: 8347500: hsdis cannot be built with Capstone.next [v2]

Yasumasa Suenaga ysuenaga at openjdk.org
Mon Jan 13 13:01:10 UTC 2025


On Mon, 13 Jan 2025 12:09:16 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update make/autoconf/lib-hsdis.m4
>>   
>>   Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
>
> make/autoconf/lib-hsdis.m4 line 43:
> 
>> 41:     if test "x$OPENJDK_TARGET_OS" != xwindows; then
>> 42:       HSDIS_LDFLAGS="-L${CAPSTONE}/lib"
>> 43:       if test $OPENJDK_TARGET_CPU_BITS -eq 64; then
> 
> Please follow our pattern for writing if statements:
> 
> Suggestion:
> 
>       if test "x$OPENJDK_TARGET_CPU_BITS" = "x64" ; then

Thanks for the comment! I applied your suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23059#discussion_r1913152666


More information about the build-dev mailing list