RFR: 8346987: [lto] gtest build fails

Tue Jan 21 08:07:35 UTC 2025

On Mon, 20 Jan 2025 16:32:11 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Is the problem that LTO does not work with gtest, and this has not yet been fixed? Or is it supposed to never work, due to how LTO and gtest interact?

LTO does not work currently with gtest;  maybe it could be fixed. Not sure how.
So for now I always disabled ( or did not enable) gtest when building LTO. This is sometimes a bit annoying and can be forgotten, that's why this PR .

> I'm don't think I like this solution. It seems very hacky, adding on just LTO flags like that. I'd need to think a bit about the problem if I'm to suggest a better alternative, though.

Yeah I agree it is a bit hacky as it is.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23173#issuecomment-2603906321
PR Comment: https://git.openjdk.org/jdk/pull/23173#issuecomment-2603908862