RFR: 8348039: testmake fails at IDEA after JDK-8347825

[Erik Joelsson]

On Mon, 20 Jan 2025 15:53:39 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> After JDK-8347825, `test:idea` started failing in the Oracle CI.
> 
> The problem is that when running in the Oracle CI, we are passing `CONF_NAME` to the topmost make. This will result in both `CONF_NAME` and `SPEC` being defined when making the nested make call in the idea.sh script, and this is not allowed.
> 
> I solved this the proper way, by unexporting the variables we have setup during make that could interfere.

test/make/TestIdea.gmk line 32:

> 30: 
> 31: # Enable the shell script to call make without us interfering.
> 32: # We will keep the $(SPEC), though, to find back to our configuration.

This comment confuses me. Why do we need to keep `SPEC` defined?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23200#discussion_r1923775553