RFR: 8348180: Remove mention of include of precompiled.hpp from the HotSpot Style Guide
Aleksey Shipilev
shade at openjdk.org
Tue Jan 21 15:11:37 UTC 2025
On Tue, 21 Jan 2025 12:29:33 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need for HotSpot devs to include the precompiled.hpp. This is the PR to reflect that.
>
> I know that there is some process around updating the style guide, but I can't find it, so I'm starting with a plain PR.
This part looks dangling now:
* precompiled.hpp is just a build time optimization, so don't rely on
it to resolve include problems.
Maybe move the line at the end of the list and phrase it as:
"* Consider adding the frequently used header includes to precompiled.hpp. This can improve build times, but the improvement needs to be validated. precompiled.hpp is just a build time optimization, so don't rely on it to resolve include problems."
-------------
PR Review: https://git.openjdk.org/jdk/pull/23210#pullrequestreview-2564920258
More information about the build-dev
mailing list