RFR: 8348039: testmake fails at IDEA after JDK-8347825 [v2]

Erik Joelsson erikj at openjdk.org
Tue Jan 21 19:04:43 UTC 2025


On Tue, 21 Jan 2025 18:24:26 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> After JDK-8347825, `test:idea` started failing in the Oracle CI.
>> 
>> The problem is that when running in the Oracle CI, we are passing `CONF_NAME` to the topmost make. This will result in both `CONF_NAME` and `SPEC` being defined when making the nested make call in the idea.sh script, and this is not allowed.
>> 
>> I solved this the proper way, by unexporting the variables we have setup during make that could interfere.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update comment
>   
>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23200#pullrequestreview-2565472772


More information about the build-dev mailing list