RFR: 8348391: Keep case if possible for TOPDIR

Magnus Ihse Bursie ihse at openjdk.org
Thu Jan 23 14:54:55 UTC 2025


On Thu, 23 Jan 2025 10:14:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> To figure out the root of the JDK build, we set the TOPDIR variable in configure. Furthermore, we clean it up using UTIL_FIXUP_PATH as we do with all paths. On Windows, this can result in the path becoming all lowercase. Since Windows paths are case insensitive, this is normally not a problem. However, we try to strip the TOPDIR from paths in several locations like this:
> 
> 
> $$(subst $$(TOPDIR)/, , $$($1_TEST_RESULTS_DIR))
> 
> 
> and that will only work if the case actually matches.

Unfortunately not, I think. On Windows, we transform paths to lower case if we need to go to short format (8.3) to make it look nicer. As far as I recall, we do not do that for any other platform. The macOS issue you are thinking about (I think) is about first do "cd MYJDK" and then configure, and then "cd myjdk" and then make. I'm actually not sure how to tackle that one, more than trying to figure out the "correct" name of the directory (which apparently is a bit tricky, according to my quick googling).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23259#issuecomment-2610011476


More information about the build-dev mailing list