Integrated: 8348586: Optionally silence make warnings about non-control variables

Magnus Ihse Bursie ihse at openjdk.org
Mon Jan 27 13:14:01 UTC 2025


On Fri, 24 Jan 2025 17:08:42 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> When you set a variable on the make command line that is not a known control variable, make emits a note like this:
> 
> 
> Note: Command line contains non-control variables:
> * MODULES=
> * IDEA_OUTPUT=/mnt/h/openjdk/git-jdk2/.idea
> Make sure it is not mistyped, and that you intend to override this variable.
> 'make help' will list known control variables.
> 
> 
> Since [JDK-8347825](https://bugs.openjdk.org/browse/JDK-8347825), this happens whenever you run idea.sh, and it is confusing to users.
> 
> I introduce a general way of silencing such complaints using the new control variable `ALLOW`, and start by applying it on the idea.sh script.

This pull request has now been integrated.

Changeset: f1e07974
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f1e07974a09e5deaecdfe0d9e18553f1cde15e2d
Stats:     14 lines in 3 files changed: 6 ins; 0 del; 8 mod

8348586: Optionally silence make warnings about non-control variables

Reviewed-by: mcimadamore, erikj

-------------

PR: https://git.openjdk.org/jdk/pull/23302


More information about the build-dev mailing list