RFR: 8292944: Noisy output when running make help the first time [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Jan 31 14:24:21 UTC 2025
> From the bug report:
> Running make help after configuring produces a lot of noisy output from make before the actual help text is displayed.
>
> Reproducer:
>
> * bash ./configure --with-boot-jdk=... --with-devkit=...
> * make help
>
> It only happens on the first invocation of make help, subsequent runs only display the actual help text.
>
> What happened was that the module-deps.gmk and find-test.gmk files where generated at an inopportune moment.
>
> Note that this PR is dependent on https://github.com/openjdk/jdk/pull/23355 (I hope I got the Skara incantations right for that...)
Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
- Merge branch 'master' into fix-noisy-help
- Add GENERATE_FIND_TESTS_FILE to RunTestPrebuilt as well
- 8292944: Noisy output when running make help the first time
- Update/clarify comments, and make some small style adjustments.
- Rename BothInitSupport to LogUtils
- Invert if block so the common case comes first. Also some additional cleanup.
- Rename SpecInit to just Init
- Remove Init.gmk
- Remove InitSupport.gmk
- Split InitSupport.gmk into three parts
- ... and 1 more: https://git.openjdk.org/jdk/compare/5878e45a...887dd179
-------------
Changes: https://git.openjdk.org/jdk/pull/23357/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23357&range=02
Stats: 19 lines in 5 files changed: 12 ins; 0 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/23357.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23357/head:pull/23357
PR: https://git.openjdk.org/jdk/pull/23357
More information about the build-dev
mailing list