RFR: 8361013: JMH does not export sufficient modules to benchmark ImageReader
Magnus Ihse Bursie
ihse at openjdk.org
Tue Jul 1 06:21:51 UTC 2025
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont <duke at openjdk.org> wrote:
> Added jimage and jrtfs exports.
> FWIW I think these changes to the makefiles are routine enough at this point that we don't need to involve someone from the build team, but they can be approved by any reviewer.
I agree. Just adding addition `--exports` do not require a build system review. With that said, Skara will label any such changes with the `build` tag, so we will get notified. But you don't have to wait for a review from the build team. If I see such changes, I usually add a "build changes trivially fine" just to acknowledge this, but as I said, it's not really a requirement.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26035#issuecomment-3022005628
More information about the build-dev
mailing list