RFR: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once [v2]
Mikael Vidstedt
mikael at openjdk.org
Tue Jul 8 21:06:38 UTC 2025
On Tue, 8 Jul 2025 20:55:17 GMT, Daniel Hu <duke at openjdk.org> wrote:
>> These changes should prevent entire binary files from being loaded into memory for build/AbsPathsInImage.java test. I chose a default buffer size of 8KB since BufferedInputStream uses that, but open to alternative solutions. GHA passes and test passes on linux x64.
>
> Daniel Hu has updated the pull request incrementally with one additional commit since the last revision:
>
> style improvements
Sorry for the potentially stupid question but: what happens if the pattern spans a chunk?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26030#issuecomment-3050295430
More information about the build-dev
mailing list