RFR: 8360459: UNICODE_CASE and character class with non-ASCII range does not match ASCII char [v2]

Xueming Shen sherman at openjdk.org
Mon Jul 14 07:58:39 UTC 2025


On Mon, 14 Jul 2025 05:08:58 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Xueming Shen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update to address the review comments
>
> make/jdk/src/classes/build/tools/generatecharacter/CaseFolding.java line 45:
> 
>> 43:         var caseFoldingTxt = Paths.get(args[1]);
>> 44:         var genSrcFile = Paths.get(args[2]);
>> 45:         var supportedTypes = "^.*; [CTS]; .*$";
> 
> Do we still need T here given you already have a hardcoded special case?

Yes, there is another T entry for the 'I's that is picked by the logic

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26285#discussion_r2204103748


More information about the build-dev mailing list