RFR: 8358515: make cmp-baseline is broken after JDK-8349665 [v2]

Magnus Ihse Bursie ihse at openjdk.org
Tue Jun 3 19:19:32 UTC 2025


On Tue, 3 Jun 2025 18:05:13 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> make/Init.gmk line 121:
> 
>> 119: 	        $(MAKE) $(MAKE_ARGS) -j 1 -f make/Main.gmk $(USER_MAKE_VARS) \
>> 120: 	        UPDATE_MODULE_DEPS=true NO_RECIPES=true \
>> 121: 	        create-main-targets-include )
> 
> That looks like a bit of extra indentation.

Does it...? *checking...* Yeah, I see what you mean. I wish there were an editor that were configurable to be actually usable when editing makefiles. (Even more than this, I wish make didn't use tab as a significant syntactic element...)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25618#discussion_r2124711388


More information about the build-dev mailing list