RFR: 8358538: Update GHA Windows runner to 2025 [v2]

[Magnus Ihse Bursie]

On Wed, 4 Jun 2025 11:24:45 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update windows version for testing
>
> .github/workflows/main.yml line 313:
> 
>> 311:     with:
>> 312:       platform: windows-x64
>> 313:       msvc-toolset-version: '14.43'
> 
> I wish I understood why `14.43`, since I don't see any reference to it in current runner docs: https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md. But I see you have tried other versions, and this one works?
> 
> From https://learn.microsoft.com/en-us/lifecycle/faq/visual-c-faq it sounds like `14.43` is not supported/final one, listed as `TBD` for start/end dates. (Compare with `14.29` for VS 2019.) `14.42` is listed as supported until July 14, 2026. I see you have tried `14.42`: https://github.com/openjdk/jdk/pull/25628/commits/6f7922f5c70e4ffef82005b3ea702673b589eb64 -- did it not work?

Yes, neither 14.44 nor 14.42, which I thought I had good reasons to believe should work did in fact work. :-( I'm not very keen on trying to debug this further. The brownouts have already started. Feel free to either take over this PR, or come up with a follow-up where you try to figure out what VS versions work...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25628#discussion_r2127047780