RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest
David Holmes
dholmes at openjdk.org
Mon Mar 3 04:55:51 UTC 2025
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> Please review the test fix that removes `libVThreadEventTest` explicit dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With the change, `libVThreadEventTest` no longer needs to be linked with `libjvm.so` (or `jvm.dll`). `VThreadEventTest.java` now runs on both dynamic and static JDK.
>
> Tested on static JDK locally
> GHA: https://github.com/jianglizhou/jdk/actions/runs/13577993687/job/37960245161
I agree that the call to `JNI_GetCreatedJavaVMs` serves no purpose.
Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23835#pullrequestreview-2653050130
More information about the build-dev
mailing list