RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest
Magnus Ihse Bursie
ihse at openjdk.org
Fri Mar 7 15:19:07 UTC 2025
On Mon, 3 Mar 2025 17:36:00 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review the test fix that removes `libVThreadEventTest` explicit dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With the change, `libVThreadEventTest` no longer needs to be linked with `libjvm.so` (or `jvm.dll`). `VThreadEventTest.java` now runs on both dynamic and static JDK.
>>
>> Tested on static JDK locally
>> GHA: https://github.com/jianglizhou/jdk/actions/runs/13577993687/job/37960245161
>
> Thanks for the reviews and historical info!
@jianglizhou I looked at this as part of my backlog, and it struck me that there are several other tests that declare a dependency to java.base:libjvm. Are these working properly on static builds?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23835#issuecomment-2706710853
More information about the build-dev
mailing list