RFR: 8351322: Parameterize link option for pthreads [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Mar 10 11:09:54 UTC 2025
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
>>> What is the intended way of using this? Do you run make with LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the specific way of linking to pthread?
>>
>> This is in preparation of the upcoming BSD port, which uses `-pthread` instead of `-pthread`. It was me who suggested that this is done separately with the existing code, to minimize the patch of the BSD port.
>
> @magicus why can't we just use `-pthread` everywhere? My recollection is that `-pthread` both sets compiler directives needed for pthread programming and links to libpthread, so it seems to be what we should be using. ??
Another follow-up is if it would hurt to include $LIBPTHREAD for *all* Hotspot tests, to avoid the huge list. @dholmes-ora Do you have anything coming to mind directly that would make that infeasible, or is it just a matter of testing to add it and see if any tests fail?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23930#issuecomment-2710217007
More information about the build-dev
mailing list