RFR: 8345940: Migrate security-related resources from Java classes to properties files [v9]
    Justin Lu 
    jlu at openjdk.org
       
    Tue Mar 11 00:37:56 UTC 2025
    
    
  
On Mon, 10 Mar 2025 17:57:42 GMT, Artur Barashev <abarashev at openjdk.org> wrote:
>> These resources files are in Java classes. If converted to properties files, the localized versions can use UTF-8 encoding directly.
>> 
>> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java
>> ./src/java.base/share/classes/sun/security/util/Resources.java
>> ./src/java.base/share/classes/sun/security/util/AuthResources.java
>> ./src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
>
> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Keep the original copyright year
Skimmed some tricky values and the conversions looked correct to me.
Since it was tested that the values are the same before and after, this change looks good to me.
-------------
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/22774#pullrequestreview-2672454949
    
    
More information about the build-dev
mailing list