RFR: 8345940: Migrate security-related resources from Java classes to properties files [v4]

Justin Lu jlu at openjdk.org
Tue Mar 11 00:37:57 UTC 2025


On Mon, 10 Mar 2025 14:33:14 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties line 40:
>> 
>>> 38: If.keystore.is.not.password.protected.then.storepass.and.keypass.must.not.be.specified=Wenn der Keystore nicht kennwortgeschützt ist, dürfen -storepass und -keypass nicht angegeben werden
>>> 39: Usage.jarsigner.options.jar.file.alias=Verwendung: jarsigner [options] jar-file alias
>>> 40: .jarsigner.verify.options.jar.file.alias.=\u0020      jarsigner -verify [options] jar-file [alias...]
>> 
>> We have generally kept `\u0020` in these properties files for the purpose of making it clear that trailing white space in a value is intentional. Can we convert these non trailing `\u0020` to just ` `?
>
> In properties files the whitespaces after `=` get trimmed when compiled, so when we replace `\u0020` with ` ` we get an incorrect string.

Ah, you're right, I am used to seeing those cases starting with `` to preserve the leading white space. Since it's just a stylistic choice, this seems fine then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22774#discussion_r1988192291


More information about the build-dev mailing list